summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOrlando Arbildo <oarbildo@google.com>2022-10-07 23:28:23 +0000
committerOrlando Arbildo <oarbildo@google.com>2022-11-18 17:20:24 +0000
commit927d80ba2bbc9f7e80413519888aa7bd538679aa (patch)
treec3b72726860dd3b54cc327bdf6a299e9f351b3da
parent30400907f8a33a210c8b49bf5782bbed19354237 (diff)
downloadgeneric-arm64-927d80ba2bbc9f7e80413519888aa7bd538679aa.tar.gz
project/generic-arm64-fuzz: Increasing IPC_MAX_HANDLES for coverage tests
Increasing IPC_MAX_HANDLES from 64 to 128 when compiling targets with coverage enabled. This was needed because we had more than 64 connections to com.android.trusty.coverage.aggregator. Bug: 258572142 Test: AppMgrWaitForPort suite on arm64 fuzz target Change-Id: Ie1ec6b5ad54d19e0661f1268b1d10083e84f57bb
-rw-r--r--project/generic-arm64-fuzz-test-debug.mk11
1 files changed, 11 insertions, 0 deletions
diff --git a/project/generic-arm64-fuzz-test-debug.mk b/project/generic-arm64-fuzz-test-debug.mk
index b9e7834..43a5d6d 100644
--- a/project/generic-arm64-fuzz-test-debug.mk
+++ b/project/generic-arm64-fuzz-test-debug.mk
@@ -19,6 +19,17 @@ CFI_DIAGNOSTICS := false
USER_COVERAGE_ENABLED := true
+# Increase the maximum number of IPC handles if coverage is enabled.
+# This is needed because currently trusty/base/lib/sancov opens more
+# than 64 connections. Doubling IPC_MAX_HANDLES is not strictly needed
+# (right now we have just hit the limit), and while a old comment on
+# IPC_MAX_HANDLES stated that it should be a multiple of sizeof(unsigned long),
+# nothing in the code seems to require such a size. Reason to set it to 128
+# is just that this is currently only enabled for fuzzing targets (on which
+# doubling the number of handles should not be a big concern), so doubling it
+# means that we should not hit this limit again soon.
+IPC_MAX_HANDLES := 128
+
# Reduce amount logs to speed up fuzzing
GLOBAL_SHARED_COMPILEFLAGS += -Wno-macro-redefined
GLOBAL_DEFINES += TLOG_LVL=1 # TLOG_LVL_CRIT