summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChih-Hung Hsieh <chh@google.com>2016-06-30 15:56:49 -0700
committerChih-Hung Hsieh <chh@google.com>2016-06-30 15:56:49 -0700
commit530fe47029e0128f3d4d1ee26a8ac8dfaf21aa90 (patch)
tree17c8f504c6575f877b41355d15f7ad4ab095135c
parente7126b88fd9683faa7d3827a244cf03865605ba6 (diff)
downloadshill-530fe47029e0128f3d4d1ee26a8ac8dfaf21aa90.tar.gz
Bug: 28341362 Change-Id: I7fbe21e702b88ca1a78c55674719caefb80a1ac6 Test: build with clang-tidy
-rw-r--r--dbus/chromeos_dbus_control.h2
-rw-r--r--dns_server_proxy.h2
-rw-r--r--test-rpc-proxy/proxy_dbus_client.h2
-rw-r--r--test-rpc-proxy/proxy_dbus_shill_wifi_client.h2
-rw-r--r--test-rpc-proxy/proxy_rpc_in_data_types.h6
-rw-r--r--test-rpc-proxy/proxy_rpc_security_types.h14
6 files changed, 14 insertions, 14 deletions
diff --git a/dbus/chromeos_dbus_control.h b/dbus/chromeos_dbus_control.h
index b05b6ee0..3c0880df 100644
--- a/dbus/chromeos_dbus_control.h
+++ b/dbus/chromeos_dbus_control.h
@@ -31,7 +31,7 @@ class Manager;
class ChromeosDBusControl : public ControlInterface {
public:
- ChromeosDBusControl(EventDispatcher* dispatcher);
+ explicit ChromeosDBusControl(EventDispatcher* dispatcher);
~ChromeosDBusControl() override;
void RegisterManagerObject(
diff --git a/dns_server_proxy.h b/dns_server_proxy.h
index 1c143fb7..876aa188 100644
--- a/dns_server_proxy.h
+++ b/dns_server_proxy.h
@@ -31,7 +31,7 @@ class ProcessManager;
// Proxy is setup using dnsmasq.
class DNSServerProxy {
public:
- DNSServerProxy(const std::vector<std::string>& dns_servers);
+ explicit DNSServerProxy(const std::vector<std::string>& dns_servers);
virtual ~DNSServerProxy();
// Start dnsmasq process for serving local DNS requests.
diff --git a/test-rpc-proxy/proxy_dbus_client.h b/test-rpc-proxy/proxy_dbus_client.h
index 2fe33bc7..905ff657 100644
--- a/test-rpc-proxy/proxy_dbus_client.h
+++ b/test-rpc-proxy/proxy_dbus_client.h
@@ -53,7 +53,7 @@ class ProxyDbusClient {
static const char kDbusErrorObjectUnknown[];
static const int kLogLevel;
- ProxyDbusClient(scoped_refptr<dbus::Bus> bus);
+ explicit ProxyDbusClient(scoped_refptr<dbus::Bus> bus);
void SetLogging(Technology tech);
std::vector<std::unique_ptr<DeviceProxy>> GetDeviceProxies();
std::vector<std::unique_ptr<ServiceProxy>> GetServiceProxies();
diff --git a/test-rpc-proxy/proxy_dbus_shill_wifi_client.h b/test-rpc-proxy/proxy_dbus_shill_wifi_client.h
index cdd6ddcc..d122cd47 100644
--- a/test-rpc-proxy/proxy_dbus_shill_wifi_client.h
+++ b/test-rpc-proxy/proxy_dbus_shill_wifi_client.h
@@ -24,7 +24,7 @@
// Client.
class ProxyDbusShillWifiClient : public ProxyShillWifiClient {
public:
- ProxyDbusShillWifiClient(scoped_refptr<dbus::Bus> dbus_bus);
+ explicit ProxyDbusShillWifiClient(scoped_refptr<dbus::Bus> dbus_bus);
~ProxyDbusShillWifiClient() override = default;
bool SetLogging() override;
bool RemoveAllWifiEntries() override;
diff --git a/test-rpc-proxy/proxy_rpc_in_data_types.h b/test-rpc-proxy/proxy_rpc_in_data_types.h
index 8eb30557..5d451bd9 100644
--- a/test-rpc-proxy/proxy_rpc_in_data_types.h
+++ b/test-rpc-proxy/proxy_rpc_in_data_types.h
@@ -32,7 +32,7 @@ class BgscanConfiguration {
static const int kDefaultSignalThreshold;
static const char kDefaultScanMethod[];
- BgscanConfiguration(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit BgscanConfiguration(XmlRpc::XmlRpcValue* xml_rpc_value_in);
std::string interface_;
int signal_threshold_;
@@ -48,7 +48,7 @@ class AssociationParameters {
static const int kDefaultAssociationTimeoutSeconds;
static const int kDefaultConfigurationTimeoutSeconds;
- AssociationParameters(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit AssociationParameters(XmlRpc::XmlRpcValue* xml_rpc_value_in);
std::string ssid_;
int discovery_timeout_seconds_;
@@ -72,7 +72,7 @@ class AssociationParameters {
// consumers of this interface look up the service by GUID.
class ConfigureServiceParameters {
public:
- ConfigureServiceParameters(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit ConfigureServiceParameters(XmlRpc::XmlRpcValue* xml_rpc_value_in);
std::string guid_;
std::string passphrase_;
diff --git a/test-rpc-proxy/proxy_rpc_security_types.h b/test-rpc-proxy/proxy_rpc_security_types.h
index d9e599d6..4b3b1030 100644
--- a/test-rpc-proxy/proxy_rpc_security_types.h
+++ b/test-rpc-proxy/proxy_rpc_security_types.h
@@ -47,7 +47,7 @@ class SecurityConfig {
// object from the incoming RPC data.
static std::unique_ptr<SecurityConfig> CreateSecurityConfigObject(
XmlRpc::XmlRpcValue* xml_rpc_value_in);
- SecurityConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit SecurityConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
virtual ~SecurityConfig() = default;
virtual void GetServiceProperties(brillo::VariantDictionary* properties);
@@ -59,7 +59,7 @@ class SecurityConfig {
// and simply start using the WEP keys after association finishes.
class WEPConfig : public SecurityConfig {
public:
- WEPConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit WEPConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
virtual void GetServiceProperties(brillo::VariantDictionary* properties) override;
private:
@@ -71,7 +71,7 @@ class WEPConfig : public SecurityConfig {
// Abstracts security configuration for a WPA encrypted WiFi network.
class WPAConfig : public SecurityConfig {
public:
- WPAConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit WPAConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
void GetServiceProperties(brillo::VariantDictionary* properties) override;
static const int kMaxPskSize;
@@ -94,7 +94,7 @@ class EAPConfig : public SecurityConfig {
static const char kDefaultEAPIdentity[];
static int last_tmp_id;
- EAPConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit EAPConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
void GetServiceProperties(brillo::VariantDictionary* properties) override;
private:
@@ -126,7 +126,7 @@ class DynamicWEPConfig : public EAPConfig {
public:
static const int kDefaultKeyPeriod;
- DynamicWEPConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit DynamicWEPConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
void GetServiceProperties(brillo::VariantDictionary* properties) override;
private:
@@ -137,7 +137,7 @@ class DynamicWEPConfig : public EAPConfig {
// Security type to set up a WPA connection via EAP-TLS negotiation.
class WPAEAPConfig : public EAPConfig {
public:
- WPAEAPConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit WPAEAPConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
void GetServiceProperties(brillo::VariantDictionary* properties) override;
private:
@@ -163,7 +163,7 @@ class Tunneled1xConfig : public WPAEAPConfig {
static const char kLayer2TypeTTLSMSCHAP[];
static const char kLayer2TypeTTLSPAP[];
- Tunneled1xConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
+ explicit Tunneled1xConfig(XmlRpc::XmlRpcValue* xml_rpc_value_in);
void GetServiceProperties(brillo::VariantDictionary* properties) override;
private: